Skip to content

[*] migrate maintenance task logic to PL/pgSQL #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[*] migrate maintenance task logic to PL/pgSQL #1025

wants to merge 10 commits into from
+123 −78

Conversation

@0xgouda
Copy link
Collaborator

@0xgouda 0xgouda commented Nov 17, 2025

  • Create new PL/pgSQL functions containing the maintenance logic.
    • admin.try_get_maintenance_lock().
    • admin.update_listing_table(metric_table_name text).
    • admin.remove_dropped_tables_listing(existing_metrics text[]).
  • Call these functions from the Golang maintenance routine.

@0xgouda 0xgouda requested a review from pashagolub November 17, 2025 03:50
@0xgouda 0xgouda added enhancement New feature or request refactoring Something done as it should've been done from the start sinks Where and how to store monitored data labels Nov 17, 2025
0xgouda added 10 commits November 17, 2025 17:39
@0xgouda @pashagolub
move maintenance lock acquisition logic to `admin.try_get_maintenance…
0c149a8 
…_lock()`
@0xgouda @pashagolub
move listing table update logic to PL/pgSQL functions.
b864423 
- move individual metric update logic to `admin.update_listing_table()`.
- move dropped tables removal logic to `admin.remove_dropped_tables_listing()`.
- use these new functions in the maintenance routine.
@0xgouda @pashagolub
Test updating tables having public. prefix in the maintenance routine.
d745d2c
@0xgouda @pashagolub
Fix linter errors.
a73a8df
@0xgouda @pashagolub
remove schema variable from admin.update_listing_table()
9020a68
@0xgouda @pashagolub
Increase tests timeout.
f840387 
- the `MaintainUniqueSources` test calls `pgw.MaintainUniqueSources()`
3 times which sleeps a minute each time.
@0xgouda @pashagolub
Drop all tables for builtin metrics to avoid timeout.
a08e940
@0xgouda @pashagolub
Fix linter error
66a9f06
@0xgouda @pashagolub
Return number of inserted/deleted rows for logging.
bb7a406
@0xgouda @pashagolub
Fix more linter errors
c245c16
@pashagolub pashagolub force-pushed the make-maintenance-in-plpgsql branch from 5c6510c to c245c16 Compare November 17, 2025 16:39
@coveralls
Copy link

coveralls commented Nov 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 19437140385

Details

  • 18 of 22 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 73.597%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/sinks/postgres.go 18 22 81.82%
Totals Coverage Status
Change from base Build 19436814112: -0.09%
Covered Lines: 3646
Relevant Lines: 4954
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pashagolub pashagolub Awaiting requested review from pashagolub

Assignees

No one assigned

Labels

enhancement New feature or request refactoring Something done as it should've been done from the start sinks Where and how to store monitored data

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xgouda @coveralls